[release-3.8] Avoid to exit while trying to install a specific kernel-devel version #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has been created to try to install using `--releasever` parameter and if this command fails try to install the package from vault, anyway the `set -e` at the top of the failing was causing all the build to fail. Manually tested in a Rocky-8-EC2-Base-8.8-20230518.0.x86_64 Related to: aws#2598 Signed-off-by: Enrico Usai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2603 +/- ##
========================================
Coverage 75.56% 75.56%
========================================
Files 16 16
Lines 2132 2132
========================================
Hits 1611 1611
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When using `wget`, the package name must contain the architecture too. By redefining the `kernel_source_package_version` we're avoiding to `chomp` the architecture from kernel version. Then, use `node['kernel']['machine']` rather than `uname -m`. ### Tests Verified that both `dnf install` and `wget` commands are working when passing architecture. ### References * https://github.com/chef/ohai/blob/17-stable/lib/ohai/plugins/kernel.rb#L34 Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
force-pushed
the
wip/rocky-kernel
branch
from
2d90eaa to
66fa22c
Compare
lukeseawalker
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Avoid to exit while trying to install a specific kernel-devel version
This code has been created to try to install using
--releaseverparameter and if this command fails try to install the package from vault, anyway theset -eat the top of the failing was causing all the build to fail.Fix kernel-devel package name for rhel8
When using
wget, the package name must contain the architecture too.By redefining the
kernel_source_package_versionwe're avoiding tochompthe architecture from kernel version.Then, use
node['kernel']['machine']rather thanuname -m.Tests
dnf installandwgetcommands are working when passing architecture.References